Skip to content

Pipe: improve exception messages for sink connection establishment and node urls validation#11826

Merged
SteveYurongSu merged 4 commits intoapache:masterfrom
VGalaxies:parse-node-urls
Jan 3, 2024
Merged

Pipe: improve exception messages for sink connection establishment and node urls validation#11826
SteveYurongSu merged 4 commits intoapache:masterfrom
VGalaxies:parse-node-urls

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

Description

As title, this PR serves as further optimizations following #11806 to provide more user-friendly information and log the root cause.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu self-requested a review January 2, 2024 11:20
@SteveYurongSu SteveYurongSu self-assigned this Jan 2, 2024
@SteveYurongSu SteveYurongSu merged commit b60005e into apache:master Jan 3, 2024
@VGalaxies VGalaxies deleted the parse-node-urls branch January 3, 2024 04:07
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
…d node urls validation (apache#11826)

Co-authored-by: Steve Yurong Su <rong@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants